Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test checking fail to fetch asset metadata #2674

Merged
merged 3 commits into from
May 27, 2021

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

ADP-925

Overview

  • d95f49f
    Add test checking fail to fetch asset metadata

Comments

@piotr-iohk piotr-iohk self-assigned this May 26, 2021
@piotr-iohk piotr-iohk requested review from rvl and Anviking May 26, 2021 15:33
2. On the wallet that has some assets check that `"metadata_error":"fetch"` is returned when getting assets.
- when listing all assets
```
$ curl -X GET http://localhost:8090/v2/wallets/73d38c71e4b8b5d71769622ab4f5bfdedbb7c39d/assets
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we mention the public key for this wallet such that anyone can run this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice idea.

In the meantime I have added instructions for how to get one of our E2E fixture wallets, using the password from our shared LastPass folder.

@rvl rvl force-pushed the piotr/adp-925/test-failfetch-metadata branch from d95f49f to b279232 Compare May 27, 2021 02:11
@rvl rvl merged commit 7426ccc into master May 27, 2021
@rvl rvl deleted the piotr/adp-925/test-failfetch-metadata branch May 27, 2021 02:12
WilliamKingNoel-Bot pushed a commit that referenced this pull request May 27, 2021
…t-failfetch-metadata

Add test checking fail to fetch asset metadata 7426ccc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants